[webkit-reviews] review denied: [Bug 235984] Fixes for non-unified builds after r288868 : [Attachment 450583] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 235984: Fixes for non-unified builds after r288868
https://bugs.webkit.org/show_bug.cgi?id=235984

Attachment 450583: patch

https://bugs.webkit.org/attachment.cgi?id=450583&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 450583
  --> https://bugs.webkit.org/attachment.cgi?id=450583
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450583&action=review

>>>> Source/WebCore/rendering/RenderInline.h:26
>>>> +#include "RenderBlockFlow.h"
>>> 
>>> What is this for? I don't see it being obviously used in this header?
>> 
>> r288868 didn't actually touch this header.
> 
> RenderInline should have no business of referencing RenderBlockFlow in the
header.

We need to see the error you are fixing with this include, so we can suggest a
better solution.