[webkit-reviews] review granted: [Bug 235985] Share more WebPage code related to marking layers volatile : [Attachment 450585] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 16:41:37 PST 2022


Chris Dumez <cdumez at apple.com> has granted  review:
Bug 235985: Share more WebPage code related to marking layers volatile
https://bugs.webkit.org/show_bug.cgi?id=235985

Attachment 450585: Patch

https://bugs.webkit.org/attachment.cgi?id=450585&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 450585
  --> https://bugs.webkit.org/attachment.cgi?id=450585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450585&action=review

>>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2853
>>> +void WebPage::markLayersVolatileOrRetry(MarkLayersVolatileStopReason
stopReason, Seconds timerInterval)
>> 
>> Why the second parameter? Can we just use
initialLayerVolatilityTimerInterval inside the function like we used to?
> 
> Because it's called from the timer callback with a new interval (2x the last
one).

Oh, I see it now (newInterval). Sorry.


More information about the webkit-reviews mailing list