[webkit-reviews] review requested: [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system : [Attachment 450566] Generate xcfilelists for rsync

[bugzilla-daemon at webkit.org]

Elliott Williams <emw at apple.com> has asked  for review:
Bug 235744: [XCBuild] WTF's headers are copied via a script and are invisible
to the build system
https://bugs.webkit.org/show_bug.cgi?id=235744

Attachment 450566: Generate xcfilelists for rsync

https://bugs.webkit.org/attachment.cgi?id=450566&action=review




--- Comment #10 from Elliott Williams <emw at apple.com> ---
Created attachment 450566

  --> https://bugs.webkit.org/attachment.cgi?id=450566&action=review

Generate xcfilelists for rsync

Here's an alternative approach ("alternative 2" in my comment above) which
scripts the creation of xcfilelists based on what rsync transfers. The idea is
that we run rsync with `-ii` to generate itemized logs, and pipe the output to
`generate-rsync-xcfilelists`. Xcode uses these xcfilelists to figure out when
to run rsync (if at all).

The xcfilelists themselves are descriptive enough to get Xcode to re-run rsync
when a file is added, so adding/removing headers to WTF will trigger it without
project file changes.

I think this *might* be the preferred approach because we have other targets
which use rsync, and while it may be viable to move away from rsync in this
particular case, I'm not sure about the others. They are:

    JavaScriptCore - testapi
    PAL - Copy PAL Headers
    libwebrtc - Copy webrtc headers