[webkit-reviews] review granted: [Bug 235951] LibWebRTCCodecs should not need to create IOSurfaces : [Attachment 450539] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 235951: LibWebRTCCodecs should not need to create IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=235951

Attachment 450539: Patch

https://bugs.webkit.org/attachment.cgi?id=450539&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 450539
  --> https://bugs.webkit.org/attachment.cgi?id=450539
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450539&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:9
> +	   Introduce helper routines to copy a webrtc VideoFrame in a memory
buffer and get a CVPixelBuffer from a webrtc VideoFrame.

s/in a memory buffer/into a memory buffer/

> Source/WebCore/platform/cocoa/SharedVideoFrameInfo.h:79
> +

Nit: extra blank line.

> Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm:210
> +    CVPixelBufferUnlockBaseAddress(rawPixelBuffer, 0);

This is unnecessary.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:70
>	   for (auto decoder : decoders.values())

`auto&`?

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:71
> +    if (!m_storage || m_storage->size() < size) {

Should we also reallocate if m_storage is (significantly?) larger than needed?

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:135
> +

Nit: extra blank

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h:96
> +

Ditto