[webkit-reviews] review granted: [Bug 235370] Move tests to pyfakefs from FileSystemMock : [Attachment 450272] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 235370: Move tests to pyfakefs from FileSystemMock
https://bugs.webkit.org/show_bug.cgi?id=235370

Attachment 450272: Patch

https://bugs.webkit.org/attachment.cgi?id=450272&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 450272
  --> https://bugs.webkit.org/attachment.cgi?id=450272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450272&action=review

>
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unitt
est.py:57
> +	   self.setUpPyfakefs()

I agree that using pyfakefs through the TestCaseMixin is the right thing to do
for this class. I'm curious if you looked at the Patcher and considered it at
all? Or was the Mixin just the natural choice because this particular set of
tests was already using setup.