[webkit-reviews] review granted: [Bug 235940] Revert OSAllocator behavior to pre-Structure-Allocator change one : [Attachment 450504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 00:53:15 PST 2022


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 235940: Revert OSAllocator behavior to pre-Structure-Allocator change one
https://bugs.webkit.org/show_bug.cgi?id=235940

Attachment 450504: Patch

https://bugs.webkit.org/attachment.cgi?id=450504&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 450504
  --> https://bugs.webkit.org/attachment.cgi?id=450504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450504&action=review

r=me

> Source/WTF/ChangeLog:42
> +	   We also fix that tryReserveUncommitted is not correctly handling
MAP_FAILED. We should not return MAP_FAILED from OSAllocator, instead,

I suggest "fix that tryReserveUncommitted is not correctly handling MAP_FAILED"
=> "fix a bug in tryReserveUncommitted where it handles MAP_FAILED
incorrectly".

> Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:116
> +void* OSAllocator::tryReserveUncommitted(size_t bytes, Usage usage, bool
writable, bool executable, bool jitCageEnabled, bool includesGuardPages)

Why remove the "OSAllocator::" qualifier for Usage?  You kept to for
tryReserveAndCommit above.  I see that it is not used for functions below. 
Maybe remove it also for tryReserveAndCommit above?


More information about the webkit-reviews mailing list