[webkit-reviews] review granted: [Bug 249830] [WinCairo] Get cap-height font metrics for initial-letter support : [Attachment 464168] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 23 15:04:12 PST 2022


Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 249830: [WinCairo] Get cap-height font metrics for initial-letter support
https://bugs.webkit.org/show_bug.cgi?id=249830

Attachment 464168: Patch

https://bugs.webkit.org/attachment.cgi?id=464168&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 464168
  --> https://bugs.webkit.org/attachment.cgi?id=464168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464168&action=review

Fix then land

> Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:81
> +    m_fontMetrics.setCapHeight(ascent);

Shouldn’t this be capHeight?


More information about the webkit-reviews mailing list