[webkit-reviews] review granted: [Bug 249006] REGRESSION (251025 at main): Language setting dropdown menu is empty in Rise of the Tomb Raider : [Attachment 463954] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 249006: REGRESSION (251025 at main): Language setting dropdown menu is empty
in Rise of the Tomb Raider
https://bugs.webkit.org/show_bug.cgi?id=249006

Attachment 463954: Patch

https://bugs.webkit.org/attachment.cgi?id=463954&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 463954
  --> https://bugs.webkit.org/attachment.cgi?id=463954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463954&action=review

> Source/WebCore/rendering/RenderObject.cpp:874
> +    return ancestorRenderer.effectiveOverflowX() != Overflow::Visible &&
ancestorRenderer.effectiveOverflowY() != Overflow::Visible;

hasNonVisibleOverflow()?

> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:42
> +  document.body.offsetHeight;

The rendering update should do the layout.

> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:49
> +  wrapper.style.transform = "translateY(0)";
> +  contents.style.visibility = "visible";

My preferred way to do this is just `document.body.classList.add('changed')`
and then just write style rules to match.