[webkit-reviews] review granted: [Bug 248854] [leading-trim][IFC] Add support for nested block containers with leading-trim: end : [Attachment 463915] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 248854: [leading-trim][IFC] Add support for nested block containers with
leading-trim: end
https://bugs.webkit.org/show_bug.cgi?id=248854

Attachment 463915: Patch

https://bugs.webkit.org/attachment.cgi?id=463915&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 463915
  --> https://bugs.webkit.org/attachment.cgi?id=463915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463915&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:725
> +    if (childrenInline()) {
> +	   setLeadingTrimForSubtree(this);
> +	   layoutInlineChildren(relayoutChildren, repaintLogicalTop,
repaintLogicalBottom);
> +	   adjustLeadingTrimAfterLayout();
> +	   return;
> +    }
> +
> +    // With block children, there's no way to tell what the last formatted
line is until after we finished laying out the subtree.
> +    setLeadingTrimForSubtree();
> +    layoutBlockChildren(relayoutChildren, maxFloatLogicalBottom);
> +    adjustLeadingTrimAfterLayout();

setLeadingTrimForSubtree(this) vs setLeadingTrimForSubtree() is but subtle.

Maybe a stack helper (LeadingTrimmer!) could make this bit less intrusive.