[webkit-reviews] review granted: [Bug 248193] [Filters] Control applying the Filter by a new enum named FilterMode : [Attachment 463659] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 248193: [Filters] Control applying the Filter by a new enum named
FilterMode
https://bugs.webkit.org/show_bug.cgi?id=248193

Attachment 463659: Patch

https://bugs.webkit.org/attachment.cgi?id=463659&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 463659
  --> https://bugs.webkit.org/attachment.cgi?id=463659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463659&action=review

> Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:118
> +	   modes = modes | FilterMode::Accelerated;

modes.add(FilterMode::Accelerated)

> Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:62
> +    OptionSet<FilterMode> modes = FilterMode::Software;

I think you can just write OptionSet here because of deduction guides.

> Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:65
> +	   modes = modes | FilterMode::Accelerated;

modes.add(FilterMode::Accelerated)