[webkit-reviews] review granted: [Bug 244434] [IFC][Integration] Do not paint ellipsis on non-visible block boxes. : [Attachment 461927] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 244434: [IFC][Integration] Do not paint ellipsis on non-visible block
boxes.
https://bugs.webkit.org/show_bug.cgi?id=244434

Attachment 461927: Patch

https://bugs.webkit.org/attachment.cgi?id=461927&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 461927
  --> https://bugs.webkit.org/attachment.cgi?id=461927
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461927&action=review

>
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.
cpp:105
> +    if (m_paintInfo.phase != PaintPhase::Foreground ||
root().style().visibility() != Visibility::Visible)

We should probably support some other PaintPhases (at least TextClip, not sure
about the others)