[webkit-reviews] review granted: [Bug 244339] [IFC][Integration] Introduce InlineContentPainter : [Attachment 461860] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 244339: [IFC][Integration] Introduce InlineContentPainter
https://bugs.webkit.org/show_bug.cgi?id=244339

Attachment 461860: Patch

https://bugs.webkit.org/attachment.cgi?id=461860&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 461860
  --> https://bugs.webkit.org/attachment.cgi?id=461860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461860&action=review

nice!

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765
> -class LayerPaintScope {

LineLayout::hitTest uses this. If this compiles it must be by accident.

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771
> +    if (!m_inlineContent)

Maybe we could eliminate these tests at some point, they shouldn't really
happen