[webkit-reviews] review granted: [Bug 244173] [LFC][IFC] text-overflow: ellipsis should not affect geometries : [Attachment 461780] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 09:01:08 PDT 2022

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 244173: [LFC][IFC] text-overflow: ellipsis should not affect geometries

Attachment 461780: Patch


--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 461780
  --> https://bugs.webkit.org/attachment.cgi?id=461780

View in context: https://bugs.webkit.org/attachment.cgi?id=461780&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872
> +	       if (!hasDamage(box))
> +		   continue;

Maybe the hasDamage(box) test could go before all the type tests too and be
done in one place only. Not sure about the inline-block case...

More information about the webkit-reviews mailing list