[webkit-reviews] review granted: [Bug 243574] AX ITM: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AXIsolatedTree::updateChildren : [Attachment 461415] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 11:06:22 PDT 2022


Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 243574: AX ITM: CrashTracer: com.apple.WebKit.WebContent at
com.apple.WebCore: WebCore::AXIsolatedTree::updateChildren
https://bugs.webkit.org/show_bug.cgi?id=243574

Attachment 461415: Patch

https://bugs.webkit.org/attachment.cgi?id=461415&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 461415
  --> https://bugs.webkit.org/attachment.cgi?id=461415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461415&action=review

> Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp:156
> +    RefPtr<AccessibilityObject> child =
downcast<AccessibilityObject>(m_children[optionIndex].get());

Should just write RefPtr instead of RefPtr<AccessibilityObject>.


More information about the webkit-reviews mailing list