[webkit-reviews] review granted: [Bug 243449] [CSS Container Queries] Update query grammar to the spec : [Attachment 461355] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 243449: [CSS Container Queries] Update query grammar to the spec
https://bugs.webkit.org/show_bug.cgi?id=243449

Attachment 461355: Patch

https://bugs.webkit.org/attachment.cgi?id=461355&action=review




--- Comment #4 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 461355
  --> https://bugs.webkit.org/attachment.cgi?id=461355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461355&action=review

> Source/WebCore/css/ContainerQueryParser.cpp:98
>  

For posterity (and anyone else looking at this patch), the `not` part is
handled just below (click expand to make it appear in the diff view).

> Source/WebCore/css/StyleRule.cpp:466
> +    , m_containerdQuery(WTFMove(query))
>  {
>  }
>  
>  StyleRuleContainer::StyleRuleContainer(const StyleRuleContainer& other)
>      : StyleRuleGroup(other)
> -    , m_filteredQuery(other.m_filteredQuery)
> +    , m_containerdQuery(other.m_containerdQuery)

typo: m_containerdQuery (extra d)

> Source/WebCore/css/StyleRule.h:303
> +    CQ::ContainerQuery m_containerdQuery;

ditto in this file