[webkit-reviews] review granted: [Bug 239921] [Modern Media Controls] the overflow button sometimes flickers : [Attachment 458630] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 239921: [Modern Media Controls] the overflow button sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=239921

Attachment 458630: Patch

https://bugs.webkit.org/attachment.cgi?id=458630&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 458630
  --> https://bugs.webkit.org/attachment.cgi?id=458630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458630&action=review

> Source/WebCore/Modules/modern-media-controls/controls/overflow-button.js:53
> +	       for (let key in contextMenuOptions)
> +		   return false;
> +	       return true;

This is clever, but it made me think twice about what it does and how it works.
Is there a more obvious, or idiomatic, way of testing for an empty object?