[webkit-reviews] review granted: [Bug 239900] Add WebKit API to turn off the URL scheme check when linkifying through Data Detectors : [Attachment 458591] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 239900: Add WebKit API to turn off the URL scheme check when linkifying
through Data Detectors
https://bugs.webkit.org/show_bug.cgi?id=239900

Attachment 458591: Patch

https://bugs.webkit.org/attachment.cgi?id=458591&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 458591
  --> https://bugs.webkit.org/attachment.cgi?id=458591
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458591&action=review

> Source/WebKit/ChangeLog:10
> +	   The URL scheme check is disabled by default for all clients that are
not Web browsers.

Probably worth a ChangeLog comment explaining why we made this default choice. 

Come to think of it, why did we make this default choice? I guess our
motivating example was Mail clients? Maybe we should enable by default just for
apps with the com.apple.developer.mail-client entitlement?