[webkit-reviews] review granted: [Bug 239867] REGRESSION (249864 at main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing : [Attachment 458569] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 239867: REGRESSION (249864 at main): [ iOS ]
TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrun
kUI is failing
https://bugs.webkit.org/show_bug.cgi?id=239867

Attachment 458569: Patch

https://bugs.webkit.org/attachment.cgi?id=458569&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 458569
  --> https://bugs.webkit.org/attachment.cgi?id=458569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458569&action=review

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:127
> +    auto webView = adoptNS([[TestWKWebView alloc]
initWithFrame:CGRectMake(0, 0, viewHeight, 375)]);

Probably worth a comment about where the value comes from.

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:137
> +    [webView
_overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 325)
maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 375)];

Probably worth a comment about where the value comes from.