[webkit-reviews] review granted: [Bug 237361] [InputElement] Selection after type change needs to follow HTML specification : [Attachment 458520] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted zsun at igalia.com's request for
review:
Bug 237361: [InputElement] Selection after type change needs to follow HTML
specification
https://bugs.webkit.org/show_bug.cgi?id=237361

Attachment 458520: Patch

https://bugs.webkit.org/attachment.cgi?id=458520&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458520
  --> https://bugs.webkit.org/attachment.cgi?id=458520
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458520&action=review

> Source/WebCore/html/HTMLTextFormControlElement.cpp:97
> +    m_cachedSelectionDirection = document.frame() &&
document.frame()->editor().behavior().shouldConsiderSelectionAsDirectional() ?
SelectionHasForwardDirection: SelectionHasNoDirection;

Why did you move this out of the initializer list? It seems like it could /
should stay in the initializer list.