[webkit-reviews] review granted: [Bug 239846] Register shared workers as service worker clients : [Attachment 458522] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 239846: Register shared workers as service worker clients
https://bugs.webkit.org/show_bug.cgi?id=239846

Attachment 458522: Patch

https://bugs.webkit.org/attachment.cgi?id=458522&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458522
  --> https://bugs.webkit.org/attachment.cgi?id=458522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458522&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:52
> +    WEBCORE_EXPORT static bool isEmpty();

This function name is super confusing. What does it mean for a
SharedWorkerProxy to be empty?
I'd suggest something like hasInstances() but I'd be open to suggestions. I
don't think we should land "isEmpty()" though.