[webkit-reviews] review granted: [Bug 239806] [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8, 16, 32, 64} methods : [Attachment 458430] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 28 00:48:45 PDT 2022
Yusuke Suzuki <ysuzuki at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 239806: [RISCV64] Implement MacroAssemblerRISCV64
branchAtomicWeakCAS{8,16,32,64} methods
https://bugs.webkit.org/show_bug.cgi?id=239806
Attachment 458430: Patch
https://bugs.webkit.org/attachment.cgi?id=458430&action=review
--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 458430
--> https://bugs.webkit.org/attachment.cgi?id=458430
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=458430&action=review
r=me with nit.D
> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3366
> + {
> + Jump success = makeBranch(Equal, temp.data(),
RISCV64Registers::zero);
> + failure.link(this);
> + return JumpList(success);
> + }
style is,
case Success: {
...
}
> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3405
> + {
> + Jump success = makeBranch(Equal, temp.data(),
RISCV64Registers::zero);
> + failure.link(this);
> + return JumpList(success);
> + }
Ditto.
> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3432
> + {
> + Jump success = makeBranch(Equal, temp.data(),
RISCV64Registers::zero);
> + failure.link(this);
> + return JumpList(success);
> + }
Ditto.
More information about the webkit-reviews
mailing list