[webkit-reviews] review granted: [Bug 239829] DisplayList::Recorder should lazily create the DrawGlyphsRecorder : [Attachment 458475] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 239829: DisplayList::Recorder should lazily create the DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=239829

Attachment 458475: Patch

https://bugs.webkit.org/attachment.cgi?id=458475&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 458475
  --> https://bugs.webkit.org/attachment.cgi?id=458475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458475&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:166
> +    if (!m_drawGlyphsRecorder)
> +	   m_drawGlyphsRecorder = makeUnique<DrawGlyphsRecorder>(*this,
m_initialScale, m_deconstructDrawGlyphs);

Can we pull this out into an ensure() function?

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:275
> +    float m_initialScale { 1 };
> +    DrawGlyphsRecorder::DeconstructDrawGlyphs m_deconstructDrawGlyphs {
DrawGlyphsRecorder::DeconstructDrawGlyphs::No };

Should these be batched up into a struct? Are we polluting the contents of the
Recorder object?