[webkit-reviews] review granted: [Bug 239781] Video playback fails when using postMessage() during a User Gesture : [Attachment 458386] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 11:58:02 PDT 2022


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 239781: Video playback fails when using postMessage() during a User Gesture
https://bugs.webkit.org/show_bug.cgi?id=239781

Attachment 458386: Patch

https://bugs.webkit.org/attachment.cgi?id=458386&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 458386
  --> https://bugs.webkit.org/attachment.cgi?id=458386
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458386&action=review

> Source/WebCore/ChangeLog:12
> +	   Certain frameworks handle user gestures by sending messages through
postMessage() to
> +	   to a non-shared worker, where the message is processed and a
response is sent back

s/to to/to/

> LayoutTests/workers/worker-user-gesture.html:11
> +    const mc = new MessageChannel();
> +    const w = new Worker("worker-user-gesture.js");

Vowels are cheap, you should use some to name these variables.


More information about the webkit-reviews mailing list