[webkit-reviews] review granted: [Bug 239657] service worker update should refresh imported scripts in addition to the main script : [Attachment 458263] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 239657: service worker update should refresh imported scripts in addition
to the main script
https://bugs.webkit.org/show_bug.cgi?id=239657

Attachment 458263: Patch

https://bugs.webkit.org/attachment.cgi?id=458263&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458263
  --> https://bugs.webkit.org/attachment.cgi?id=458263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458263&action=review

r=me

> Source/WebCore/workers/service/server/SWServer.cpp:567
> +	       m_scripts.append(std::make_pair(url, WTFMove(result.script)));

Can probably just:
m_scripts.append({ url, WTFMove(result.script) });

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:114
> +	   RELEASE_LOG(ServiceWorker, "%p -
SWServerJobQueue::scriptFetchFinished, script, certificate and imported scripts
are matching for registrationID=%llu", this,
registration->identifier().toUInt64());

%llu -> PRIu64

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:135
> +	   RELEASE_LOG(ServiceWorker, "%p -
SWServerJobQueue::importedScriptsFetchFinished, script, certificate and
imported scripts are matching for registrationID=%llu", this,
registration->identifier().toUInt64());

PRIu64