[webkit-reviews] review granted: [Bug 239755] Ensure completion handler is called in SWServer::clear : [Attachment 458325] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 239755: Ensure completion handler is called in SWServer::clear
https://bugs.webkit.org/show_bug.cgi?id=239755

Attachment 458325: Patch

https://bugs.webkit.org/attachment.cgi?id=458325&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 458325
  --> https://bugs.webkit.org/attachment.cgi?id=458325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:348
> +    if (m_registrationStore) {

I would reverse the check, something like:
if (! m_registrationStore) { completionHandler(); return; }