[webkit-reviews] review granted: [Bug 239744] [iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately] : [Attachment 458309] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 239744: [iOS] Infinite recursion at -[WKFullScreenWindowController
_exitFullscreenImmediately]
https://bugs.webkit.org/show_bug.cgi?id=239744

Attachment 458309: Patch

https://bugs.webkit.org/attachment.cgi?id=458309&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 458309
  --> https://bugs.webkit.org/attachment.cgi?id=458309
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458309&action=review

> Source/WebCore/dom/FullscreenManager.cpp:116
> +    INFO_LOG(LOGIDENTIFIER);

This happens infrequently enough I think it might as well use ALWAYS_LOG.

> Source/WebCore/dom/FullscreenManager.cpp:293
> +    INFO_LOG(LOGIDENTIFIER);

Ditto

> Source/WebCore/dom/FullscreenManager.cpp:640
> +    INFO_LOG(LOGIDENTIFIER, flag);

Ditto

> Source/WebCore/dom/FullscreenManager.cpp:658
> +    INFO_LOG(LOGIDENTIFIER, flag);

Ditto