[webkit-reviews] review granted: [Bug 239425] Web Inspector: [Flexbox] `<button>` and `<select>` elements are appearing in list of Flex containers : [Attachment 458216] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 239425: Web Inspector: [Flexbox] `<button>` and `<select>` elements are
appearing in list of Flex containers
https://bugs.webkit.org/show_bug.cgi?id=239425

Attachment 458216: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=458216&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 458216
  --> https://bugs.webkit.org/attachment.cgi?id=458216
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=458216&action=review

r=me, neat!

> Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:948
> +    }

NIT: should we have a `return std::nullopt` so that we don't futilely attempt
to `is<RenderGrid>(renderer)`?

> LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html:187
> +

NIT: i'd remove this so that it doesn't affect the expected output ��