[webkit-reviews] review denied: [Bug 239493] [WASM-GC] Introduce rtt types : [Attachment 458242] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has denied Dmitry
<dbezhetskov at igalia.com>'s request for review:
Bug 239493: [WASM-GC] Introduce rtt types
https://bugs.webkit.org/show_bug.cgi?id=239493

Attachment 458242: Patch

https://bugs.webkit.org/attachment.cgi?id=458242&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 458242
  --> https://bugs.webkit.org/attachment.cgi?id=458242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458242&action=review

Looks good to me but you have a typo in your error message.

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:1052
> +	       WASM_VALIDATOR_FAIL_IF(typeIndex >= m_info.typeCount(),
"rtt.canon index ", typeIndex, " is out of bound");

typo: bound => bounds.