[webkit-reviews] review canceled: [Bug 239070] Constructed FormData object should not contain an entry for the submit button that was used to submit the form : [Attachment 458265] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 25 07:20:48 PDT 2022


Chris Dumez <cdumez at apple.com> has canceled zsun at igalia.com's request for
review:
Bug 239070: Constructed FormData object should not contain an entry for the
submit button that was used to submit the form
https://bugs.webkit.org/show_bug.cgi?id=239070

Attachment 458265: Patch

https://bugs.webkit.org/attachment.cgi?id=458265&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458265
  --> https://bugs.webkit.org/attachment.cgi?id=458265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458265&action=review

> Source/WebCore/html/HTMLFormElement.cpp:422
> +	       if (auto* control =
dynamicDowncast<HTMLFormControlElement>(element.get());
control->isSuccessfulSubmitButton()) {

Please add missing control null check.


More information about the webkit-reviews mailing list