[webkit-reviews] review granted: [Bug 239677] Web Inspector: request interception should not be guarded based on service workers : [Attachment 458201] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 23 10:25:46 PDT 2022


Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 239677: Web Inspector: request interception should not be guarded based on
service workers
https://bugs.webkit.org/show_bug.cgi?id=239677

Attachment 458201: Patch

https://bugs.webkit.org/attachment.cgi?id=458201&action=review




--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 458201
  --> https://bugs.webkit.org/attachment.cgi?id=458201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458201&action=review

r=me

> Source/WebCore/inspector/InspectorInstrumentation.cpp:848
> +bool
InspectorInstrumentation::shouldInterceptRequestImpl(InstrumentingAgents&
instrumentingAgents, ResourceLoader& loader)

As far as I can tell, everything we do with the ResourceLoader can be done with
a const ref – is there a reason we aren't passing `const ResourceLoader&`
throughout instead?

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:1121
> +    return shouldIntercept(loader.request().url(),
Protocol::Network::NetworkStage::Request);

Nit: I think we can just `loader.url()`


More information about the webkit-reviews mailing list