[webkit-reviews] review granted: [Bug 239680] Reduce sizeof(CSSNumericType) : [Attachment 458191] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 239680: Reduce sizeof(CSSNumericType)
https://bugs.webkit.org/show_bug.cgi?id=239680

Attachment 458191: Patch

https://bugs.webkit.org/attachment.cgi?id=458191&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 458191
  --> https://bugs.webkit.org/attachment.cgi?id=458191
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458191&action=review

> Source/WebCore/css/typedom/numeric/CSSNumericType.h:39
> +    using BaseTypeStorage = Markable<int, IntegralMarkableTraits<int,
std::numeric_limits<int>::min()>>;

We handle INT_MIN as nullopt value, is it correct for these types?
If it is ok, then r=me.