[webkit-reviews] review granted: [Bug 239676] Web Inspector: response overrides with an error status code should indicate that somewhere : [Attachment 458187] Patch

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 239676: Web Inspector: response overrides with an error status code should
indicate that somewhere
https://bugs.webkit.org/show_bug.cgi?id=239676

Attachment 458187: Patch

https://bugs.webkit.org/attachment.cgi?id=458187&action=review




--- Comment #2 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 458187
  --> https://bugs.webkit.org/attachment.cgi?id=458187
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458187&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:1
11
>	   // Do nothing. Do not allow ResourceTreeElement /
SourceCodeTreeElement to modify our status element.

I think the "Do nothing" part of this is contradicted now ��. (As an aside, I
had to read this comment a few times before I realized it was trying to explain
why we don't let `super` be called.)