[webkit-reviews] review granted: [Bug 239636] Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications : [Attachment 458170] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 239636: Add WKNotification and WKWebsiteDataStore SPI for handling
click/close of persistent notifications
https://bugs.webkit.org/show_bug.cgi?id=239636

Attachment 458170: Patch

https://bugs.webkit.org/attachment.cgi?id=458170&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458170
  --> https://bugs.webkit.org/attachment.cgi?id=458170
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458170&action=review

> Source/WebCore/Modules/notifications/NotificationDataCocoa.mm:72
> +    NotificationData data { title, body, iconURL, tag, language, direction,
originString, URL { String { serviceWorkerRegistrationURL } }, *uuid,
PAL::SessionID { sessionID.unsignedLongLongValue }, { } };

Return we could just:
return { title, body, iconURL, tag, language, direction, originString, URL {
String { serviceWorkerRegistrationURL } }, *uuid, PAL::SessionID {
sessionID.unsignedLongLongValue }, { } };

> Tools/WebKitTestRunner/cocoa/WebNotificationProviderCocoa.mm:39
> +	   RetainPtr<NSDictionary> dictionaryRepresentation =
adoptNS(WKNotificationCopyDictionaryRepresentation(notification.get()));

could use auto.