[webkit-reviews] review granted: [Bug 239585] Move global AtomStrings to a common header to promote reuse : [Attachment 458103] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 239585: Move global AtomStrings to a common header to promote reuse
https://bugs.webkit.org/show_bug.cgi?id=239585

Attachment 458103: Patch

https://bugs.webkit.org/attachment.cgi?id=458103&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 458103
  --> https://bugs.webkit.org/attachment.cgi?id=458103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458103&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:322
> +    WebCore::initializeCommonAtomStrings();

As a reluctant expert in JSC::initialize(), WTF::initialize(), and
WTF::initializeMainThread(), I am saddened to see yet another "make sure to
call this initialization function at various entrypoints otherwise you will
crash". Can we fold common atom string initialization into  some other
initialization function? Maybe just fold it into AtomString::init()?

In the ideal world, the set of top-level initialization functions should shrink
over time. Maybe we can even get down to just two, one for WebKit and one for
JSC.