[webkit-reviews] review granted: [Bug 239641] Bail out from text decoration computation if none is requested : [Attachment 458120] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 239641: Bail out from text decoration computation if none is requested
https://bugs.webkit.org/show_bug.cgi?id=239641

Attachment 458120: Patch

https://bugs.webkit.org/attachment.cgi?id=458120&action=review




--- Comment #2 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 458120
  --> https://bugs.webkit.org/attachment.cgi?id=458120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458120&action=review

> Source/WebCore/rendering/TextDecorationPainter.cpp:413
> +    if (requestedDecorations.isEmpty())
> +	   return { };

Can we use the same more strict check like above? or does that cause issues?
Fwiw, blink isn't supported, and none should do nothing.