[webkit-reviews] review granted: [Bug 239612] [iOS] Add find interaction API to WKWebView : [Attachment 458082] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 14:31:10 PDT 2022


Alex Christensen <achristensen at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 239612: [iOS] Add find interaction API to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=239612

Attachment 458082: Patch

https://bugs.webkit.org/attachment.cgi?id=458082&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 458082
  --> https://bugs.webkit.org/attachment.cgi?id=458082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458082&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1466
> +#endif // HAVE(UIFINDINTERACTION)

You might want to have #else - (UIFindInteraction *)findInteraction { return
nil; } - (BOOL)findInteractionEnabled { return NO; } -
(void)setFindInteractionEnabled:(BOOL)enabled { }


More information about the webkit-reviews mailing list