[webkit-reviews] review granted: [Bug 239555] Avoid falling back to snapshots for transparent images when triggering batch text recognition : [Attachment 458017] Reupload

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 239555: Avoid falling back to snapshots for transparent images when
triggering batch text recognition
https://bugs.webkit.org/show_bug.cgi?id=239555

Attachment 458017: Reupload

https://bugs.webkit.org/attachment.cgi?id=458017&action=review




--- Comment #5 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 458017
  --> https://bugs.webkit.org/attachment.cgi?id=458017
Reupload

View in context: https://bugs.webkit.org/attachment.cgi?id=458017&action=review

> Source/WebCore/platform/TextRecognitionOptions.h:32
> +enum class AllowSnapshots : bool { No, Yes };

Consider moving this inside `TextRecognitionOptions` or renaming to something
more specific.

`WebCore::AllowSnapshots` seems too generic to be defined in this header.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:107
> +class CGImagePixelReader {

I wonder if we can share this logic with other tests – maybe leave a FIXME
here? I think there are some PDF / GraphicsContext tests that also read pixels.