[webkit-reviews] review denied: [Bug 239496] [GPUProcess][Unix] RemoteRenderingBackendProxy::DidCreateWakeUpSemaphoreForDisplayListStream is never sent : [Attachment 457892] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 239496: [GPUProcess][Unix]
RemoteRenderingBackendProxy::DidCreateWakeUpSemaphoreForDisplayListStream is
never sent
https://bugs.webkit.org/show_bug.cgi?id=239496

Attachment 457892: Patch

https://bugs.webkit.org/attachment.cgi?id=457892&action=review




--- Comment #4 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 457892
  --> https://bugs.webkit.org/attachment.cgi?id=457892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457892&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:107
>      m_streamConnection->open();

This line starts invoking the virtual functions from the other thread.
The vptr of the object is set up by the constructor and is not thread-safe, so
this cannot happen in the constructor.
The bug was fixed in bug 239399