[webkit-reviews] review granted: [Bug 239483] Implement most of CSS typed OM object stringifiers : [Attachment 457930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 19 15:23:47 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 239483: Implement most of CSS typed OM object stringifiers
https://bugs.webkit.org/show_bug.cgi?id=239483

Attachment 457930: Patch

https://bugs.webkit.org/attachment.cgi?id=457930&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 457930
  --> https://bugs.webkit.org/attachment.cgi?id=457930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457930&action=review

> Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp:64
> +    serialize(builder, false, false);

Can we use an OptionSet<> instead of two bools? Hard to know what false, false
mean here.

> Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp:79
> +    if (!withoutParentheses)

Double negative makes my brain hurt.


More information about the webkit-reviews mailing list