[webkit-reviews] review granted: [Bug 238181] Parsing of contain-intrinsic-size and adding a runtime flag for it : [Attachment 457708] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 238181: Parsing of contain-intrinsic-size and adding a runtime flag for it
https://bugs.webkit.org/show_bug.cgi?id=238181

Attachment 457708: Patch

https://bugs.webkit.org/attachment.cgi?id=457708&action=review




--- Comment #23 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 457708
  --> https://bugs.webkit.org/attachment.cgi?id=457708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457708&action=review

Don't forget to fix RenderStyle::diff() in this or a future patch.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:240
> +    unsigned containIntrinsicWidthType : 2;
> +    unsigned containIntrinsicHeightType : 2;

Add a `// ContainIntrinsicSizeType` comment on both lines

> Source/WebCore/style/StyleBuilderCustom.h:2167
> +    CSSPropertyID newId =
CSSProperty::resolveDirectionAwareProperty(CSSPropertyContainIntrinsicBlockSize
, style.direction(), style.writingMode());

Maybe `auto resolvedID = `