[webkit-reviews] review granted: [Bug 239423] [macOS] Image controls are editable and prevent drops in editable web views : [Attachment 457755] For EWS

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 239423: [macOS] Image controls are editable and prevent drops in editable
web views
https://bugs.webkit.org/show_bug.cgi?id=239423

Attachment 457755: For EWS

https://bugs.webkit.org/attachment.cgi?id=457755&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 457755
  --> https://bugs.webkit.org/attachment.cgi?id=457755
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=457755&action=review

> Source/WebCore/dom/mac/ImageControlsMac.cpp:93
> +    controlLayer->setContentEditable("false"_s);

Mildly sad that we allocate and then deallocate the String containing "false"
here. There is, however, a clean way to fix that. We can change
HTMLElement::setContentEditable to take a StringView. Will still work with the
String&& that the JavaScript bindings will pass to it. Probably will have to
edit DOMHTMLElement.mm to keep it compiling since an NSString * knows how to
turn itself into a String but not a StringView. Not really necessary to do
*any* of this as part of this patch, just something I am noticing in passing.