[webkit-reviews] review granted: [Bug 239402] AXIsolatedTree::updateNode cannot attach the platform wrapper to the replacement node on the main thread. : [Attachment 457724] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 239402: AXIsolatedTree::updateNode cannot attach the platform wrapper to
the replacement node on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=239402

Attachment 457724: Patch

https://bugs.webkit.org/attachment.cgi?id=457724&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 457724
  --> https://bugs.webkit.org/attachment.cgi?id=457724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457724&action=review

> Source/WebCore/ChangeLog:14
> +	   AXIsolatedTree::updateNode is called for existing IsolatedObjects
that
> +	   are being accessed on the AX thread through their platform wrappers.
> +	   For that reason, updateNode cannot attach a new IsolatedObject to
the
> +	   same wrapper on the main thread. Instead, the wrapper should be
added to
> +	   the NodeChange struct in order to be attached to the IsolatedObject
on
> +	   the AX thread.

Can we make a regression test?