[webkit-reviews] review granted: [Bug 238558] REGRESSION(r288847): GPU Process crash under GPUProcess::canExitUnderMemoryPressure() : [Attachment 457664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 14:10:37 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 238558: REGRESSION(r288847): GPU Process crash under
GPUProcess::canExitUnderMemoryPressure()
https://bugs.webkit.org/show_bug.cgi?id=238558

Attachment 457664: Patch

https://bugs.webkit.org/attachment.cgi?id=457664&action=review




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 457664
  --> https://bugs.webkit.org/attachment.cgi?id=457664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457664&action=review

> Source/WebKit/ChangeLog:19
> +	   Remove
RemoteMediaPlayerManagerProxy::allowsExitUnderMemoryPressure(),
> +	   the count is now counted by RemoteMediaPlayerProxy creation,
destruction.

I don't understand this part. Where does RemoteMediaPlayerManagerProxy use
ScopedRenderingResourcesRequest?


More information about the webkit-reviews mailing list