[webkit-reviews] review granted: [Bug 239372] Use the ProcessTerminationReason enum for all the process types : [Attachment 457670] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 239372: Use the ProcessTerminationReason enum for all the process types
https://bugs.webkit.org/show_bug.cgi?id=239372

Attachment 457670: Patch

https://bugs.webkit.org/attachment.cgi?id=457670&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 457670
  --> https://bugs.webkit.org/attachment.cgi?id=457670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review

> Source/WebKit/Shared/ProcessTerminationReason.cpp:55
> +

ASSERT_NOT_REACHED() ?

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:429
> +	   RELEASE_LOG_ERROR(Process, "%p - GPUProcessProxy::gpuProcessExited:
reason=%s", this, processTerminationReasonToString(reason));

Needs to be %{public}s or we won't see the reason on production builds.

> Source/WebKit/UIProcess/WebProcessPool.cpp:476
> +    WEBPROCESSPOOL_RELEASE_LOG(Process, "gpuProcessDidExit: PID=%d,
reason=%s", identifier, processTerminationReasonToString(reason));

Needs to be %{public}s or we won't see the reason on production builds.