[webkit-reviews] review granted: [Bug 239332] [JSC] ShadowRealm global object has a mutable prototype : [Attachment 457649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 15:09:39 PDT 2022


Yusuke Suzuki <ysuzuki at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 239332: [JSC] ShadowRealm global object has a mutable prototype
https://bugs.webkit.org/show_bug.cgi?id=239332

Attachment 457649: Patch

https://bugs.webkit.org/attachment.cgi?id=457649&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 457649
  --> https://bugs.webkit.org/attachment.cgi?id=457649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457649&action=review

> Source/JavaScriptCore/runtime/JSObject.cpp:1920
> +    ASSERT((this->isGlobalObject() &&
this->globalObject()->isOrdinaryObject())

isOrdinaryObject should be removed.


More information about the webkit-reviews mailing list