[webkit-reviews] review granted: [Bug 239019] calc(): Serialize top level min/max/hypot as calc() : [Attachment 457646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 14:04:53 PDT 2022


Darin Adler <darin at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 239019: calc(): Serialize top level min/max/hypot as calc()
https://bugs.webkit.org/show_bug.cgi?id=239019

Attachment 457646: Patch

https://bugs.webkit.org/attachment.cgi?id=457646&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 457646
  --> https://bugs.webkit.org/attachment.cgi?id=457646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457646&action=review

> Source/WebCore/css/calc/CSSCalcOperationNode.h:74
> +    bool shouldNotPreserveFunction() const { return isMinOrMaxNode() ||
isHypotNode(); }

I think this can also be private.


More information about the webkit-reviews mailing list