[webkit-reviews] review denied: [Bug 239336] Update in-field icons for credential fields : [Attachment 457633] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has denied Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 239336: Update in-field icons for credential fields
https://bugs.webkit.org/show_bug.cgi?id=239336

Attachment 457633: Patch

https://bugs.webkit.org/attachment.cgi?id=457633&action=review




--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 457633
  --> https://bugs.webkit.org/attachment.cgi?id=457633
Patch

These SVGs could be optimized further, clip-paths can be shapes directly,
classes can be put as attributes directly, etc. As an example:

```
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" opacity=".775">
	<path fill="#e5e5e5"
d="M7.692,0h8.617c2.675,0,3.644,.278,4.622,.801,.978,.523,1.745,1.29,2.268,2.26
8,.523,.978,.801,1.948,.801,4.622v8.617c0,2.675-.278,3.644-.801,4.622-.523,.978
-1.29,1.745-2.268,2.268-.978,.523-1.948,.801-4.622,.801H7.692c-2.675,0-3.644-.2
78-4.622-.801-.978-.523-1.745-1.29-2.268-2.268C.278,19.953,0,18.983,0,16.308V7.
692C0,5.017,.278,4.047,.801,3.069c.523-.978,1.29-1.745,2.268-2.268,.978-.523,1.
948-.801,4.622-.801Z"/>
	<path
d="M8.838,7.318c-.308,0-.57-.108-.787-.325-.217-.217-.325-.478-.325-.785s.108-.
57,.323-.787c.215-.217,.478-.325,.789-.325,.303,0,.564,.109,.782,.327,.218,.218
,.327,.48,.327,.785,0,.306-.109,.568-.327,.785-.218,.217-.479,.325-.782,.325Zm0
-3.84c-.59,0-1.139,.108-1.648,.324-.509,.216-.956,.517-1.341,.903-.385,.386-.68
6,.833-.904,1.341-.218,.508-.326,1.055-.326,1.641,0,.571,.106,1.112,.317,1.622,
.211,.51,.51,.961,.896,1.352,.386,.391,.841,.698,1.366,.918v6.082c0,.101,.018,.
196,.054,.287,.036,.091,.092,.173,.167,.247l1.122,1.077c.083,.078,.19,.12,.32,.
126,.13,.006,.244-.039,.343-.136l1.998-1.998c.104-.105,.155-.227,.153-.365-.002
-.138-.054-.26-.157-.365l-1.094-1.083,1.555-1.553c.101-.102,.151-.223,.149-.361
-.001-.138-.054-.26-.158-.365l-1.488-1.496c.929-.411,1.644-.964,2.142-1.66,.499
-.696,.748-1.472,.748-2.329,0-.581-.109-1.126-.327-1.635-.218-.509-.52-.956-.90
5-1.341s-.833-.687-1.343-.905c-.51-.218-1.057-.327-1.639-.327Z"/>
	<path
d="M18.091,14.574c.108-.002,.207-.023,.296-.064,.09-.041,.179-.105,.268-.193l2.
462-2.522c.126-.124,.189-.278,.189-.46,0-.124-.03-.237-.091-.34-.061-.103-.141-
.185-.242-.245-.101-.061-.212-.091-.334-.091-.187,0-.352,.073-.495,.22l-2.165,2
.249h.232l-2.175-2.249c-.145-.147-.311-.22-.497-.22-.122,0-.234,.03-.334,.091-.
101,.061-.182,.142-.242,.245-.061,.103-.091,.216-.091,.34,0,.09,.015,.173,.046,
.248,.031,.075,.078,.146,.14,.212l2.467,2.521c.171,.171,.36,.256,.565,.256Z"/>
</svg>
```