[webkit-reviews] review granted: [Bug 239070] Constructed FormData object should not contain an entry for the submit button that was used to submit the form : [Attachment 457610] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted zsun at igalia.com's request for
review:
Bug 239070: Constructed FormData object should not contain an entry for the
submit button that was used to submit the form
https://bugs.webkit.org/show_bug.cgi?id=239070

Attachment 457610: Patch

https://bugs.webkit.org/attachment.cgi?id=457610&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 457610
  --> https://bugs.webkit.org/attachment.cgi?id=457610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457610&action=review

r=me with improvement suggestion.

> Source/WebCore/html/HTMLFormElement.cpp:422
> +	       if (is<HTMLFormControlElement>(element)) {

if (auto* control = dynamicDowncast<HTMLFormControlElement>(element);
control.isSuccessfulSubmitButton()) {
     submitter = control;
     break;
}