[webkit-reviews] review granted: [Bug 239131] Add logging for persistent notification event handler failure : [Attachment 457347] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 239131: Add logging for persistent notification event handler failure
https://bugs.webkit.org/show_bug.cgi?id=239131

Attachment 457347: Patch

https://bugs.webkit.org/attachment.cgi?id=457347&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 457347
  --> https://bugs.webkit.org/attachment.cgi?id=457347
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457347&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:1376
> +		   RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service
Worker notification event handler did not succeed");

Shouldn't that be !succeeded ?