[webkit-reviews] review granted: [Bug 239314] Use [AtomString] where appropriate in IDL files for performance : [Attachment 457575] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <ashvayka at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 239314: Use [AtomString] where appropriate in IDL files for performance
https://bugs.webkit.org/show_bug.cgi?id=239314

Attachment 457575: Patch

https://bugs.webkit.org/attachment.cgi?id=457575&action=review




--- Comment #3 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 457575
  --> https://bugs.webkit.org/attachment.cgi?id=457575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457575&action=review

Nice!

> Source/WebCore/dom/Document.idl:61
> +    [NewObject, ImplementedAs=createElementForBindings] Element
createElement([AtomString] DOMString localName); // FIXME: missing options
parameter.

unrelated nit: we might want to remove this FIXME as `options` parameter is
part of customised built-ins API which we won't implement.

> Source/WebCore/dom/Document.idl:62
> +    [NewObject] Element createElementNS([AtomString] DOMString?
namespaceURI, [AtomString] DOMString qualifiedName); // FIXME: missing options
parameter.

ditto